Skip to content

Comments

Updating runAsNonRoot support for Windows#30256

Merged
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
marosset:windows-runasnonroot-updates
Oct 29, 2021
Merged

Updating runAsNonRoot support for Windows#30256
k8s-ci-robot merged 1 commit intokubernetes:mainfrom
marosset:windows-runasnonroot-updates

Conversation

@marosset
Copy link
Contributor

@marosset marosset commented Oct 26, 2021

Signed-off-by: Mark Rossetti marosset@microsoft.com

In v1.20 support for runAsNonRoot on Windows was added to the kubelet.
This PR updates documentation to reflect those changes.

I am also fixing a few minor typos.

/sig windows

@marosset
Updating runAsNonRoot support for Windows
afbb133 
Signed-off-by: Mark Rossetti <marosset@microsoft.com>
@k8s-ci-robot k8s-ci-robot added sig/windows Categorizes an issue or PR as relevant to SIG Windows. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 26, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Oct 26, 2021
@marosset marosset mentioned this pull request Oct 26, 2021
Merged
@marosset
Copy link
Contributor Author

marosset commented Oct 26, 2021

/assign @jsturtevant @perithompson for SIG-Windows review.

@netlify
Copy link

netlify bot commented Oct 26, 2021

✔️ Deploy Preview for kubernetes-io-main-staging ready!

🔨 Explore the source changes: afbb133

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/617864a5f673fe0007809bb1

😎 Browse the preview: https://deploy-preview-30256--kubernetes-io-main-staging.netlify.app

@jsturtevant
Copy link
Contributor

jsturtevant commented Oct 27, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 27, 2021
@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 27, 2021

LGTM label has been added.

DetailsGit tree hash: 3bb2db5bc9ceffefe14ae898ce53bb008bc2d6c3

@divya-mohan0209
Copy link
Contributor

divya-mohan0209 commented Oct 27, 2021

LGTM from an initial SIG DOCS review. Since this is external website facing, waiting for another reviewer to mark it as approved.

@perithompson
Copy link
Contributor

perithompson commented Oct 27, 2021

/lgtm
/approve

@marosset
Copy link
Contributor Author

marosset commented Oct 29, 2021

/assign @tengqm
Can you take a second look as a docs approver?
Thanks!

@reylejano
Copy link
Member

reylejano commented Oct 29, 2021

Preview of updated page:
https://deploy-preview-30256--kubernetes-io-main-staging.netlify.app/docs/setup/production-environment/windows/intro-windows-in-kubernetes/

This PR has an lgtm and approve from SIG Windows
and also an lgtm from SIG Docs

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Oct 29, 2021

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: perithompson, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 29, 2021
@k8s-ci-robot k8s-ci-robot merged commit bc785b9 into kubernetes:main Oct 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jayunit100 jayunit100 Awaiting requested review from jayunit100

@perithompson perithompson Awaiting requested review from perithompson

Assignees

@jsturtevant jsturtevant

@tengqm tengqm

@perithompson perithompson

@reylejano reylejano

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@marosset @jsturtevant @k8s-ci-robot @divya-mohan0209 @perithompson @reylejano @tengqm